CIRS Review Comments
====================

Throughout:

.TXT files usually have a minimal attached label and are not DOCUMENT
OBJECTs but TEXT OBJECTs. This is true especially for *INFO.TXT files,
AAREADME.TXT, ERRATA.TXT.
(See the label attached to your AAREADME.TXT for an example.)

CALIB directory:

There are to be no CALIB files for Jupiter?

CALINFO.TXT lists DATASET but this should be DATASET.LST (if present).


DOCUMENT directory:
LaTeX files should be given the extension .TEX
The pvt error for DATASIS.TXT (or .TEX) can then be ignored.

Some of the files in here are given as TABLE OBJECTs but they are labeled
more like they are DOCUMENT OBJECTs. (The C23*SUM.TAB files)
These files are also a bit short on useful descriptions of what they contain.
We might need another iteration on these files. You might also check
out the recently created SPREADSHEET OBJECT to see if this will fit
the needs of these files.

Cannot have mixed case filenames. Must be either all upper case or all 
 lower case.

For the figure labels, use PS_DOCUMENT or EPS_DOCUMENT as appropriate
instead of POSTSCRIPT_DOCUMENT. Also use TIFF_DOCUMENT instead of TIFF_IMAGE.


INDEX directory:
INDEX.LBL is missing the value for DATA_SET_ID.

The VOLUME_ID in the INDEX.TAB is incorrect.


CATALOG directory:
REFERENCE_KEY_ID can not have spaces. Also this reference information
should be sent to Diane Conner to be included in the PROJREF.CAT file
or else included in a CIRSREF.CAT file.

TARGET_DESCRIPTION keyword should be TARGET_DESC.

DATASET.CAT has keyword INSTRUMEN_HOST_ID instead of INSTRUMENT_HOST_ID.

PERSON.CAT has some blank values. Please fill with "N/A" or "UNK" as
appropriate.


DATA directories:
Remove trailing Z from START_TIME and STOP_TIME and PRODUCT_CREATION_TIME.

.FMT files should not have labels of their own (since they are technically
parts of labels).

You are using RECORD_TYPE = UNKNOWN to describe the .VAR files. Please
refer to Chapter 15 of the PDS Standards Reference and choose either
VARIABLE_LENGTH or UNDEFINED.

You are using TARGET_NAME = "JR" for Jupiter Rings but the correct
value should be "J RINGS".

I believe that MGS TES used DATASET.LST instead of DATASET.TXT. I would
encourage parallel usage in this instance.

DATAINFO.TXT lists DATASET but this should be DATASET.LST (if present).

^TABLE pointers should be inside the FILE OBJECT.

TARGET_NAME values should list all targets which might be found in
an individual file. Simply assigning this to the NAV_DATA files is
not satisfactory. There must be a better way of knowing this before
the files get written.

The keyword ROW_BYTES ends up in labels twice - once in the FILE OBJECT
and again in the .FMT file. The .FMT file location should be kept and
the other removed.

FILE_RECORDS should be added to the .VAR FILE OBJECTs. 



SOFTWARE directory:

DOC/vanilla-guide.LBL has INTERCHANGE_FORMAT = TEXT instead of ASCII.

Hard coded paths to locations such as "/usr/local/bin/vanilla" need to
be replaced with environment variables in all of the CIRS* software
if it is to be included in the archive.

As noted in the DATA directories section, .FMT files should not have separate
labels of their own. 


Individual file comments:


AAREADME.TXT:
Under PDS LABEL FORMAT, you refer to the labels as being attached to the .DAT
files but this is not true any more. This statement is also repeated under
TABULAR FILE FORMAT.

Typo in line 40.
Typo in line 155.
Typo in line 192.

Volume contents incomplete. CALIB directory missing, DOCUMENT directory
incomplete.

I would like to request that you follow the format of the Galileo PPR AAREADME
files for ease of reading.

ERRATA.TXT:

I would like to request that you follow the format of the Galileo PPR ERRATA
files for ease of reading.


VOLDESC.CAT:

The value for VOLUME_VERSION_ID should be "VERSION 1".
The value for VOLUME_SET_ID should be USA_NASA_PDS_COCIRS_xxxx.
The keyword MEDIUM_FORMAT can be removed.





DATASET.CAT:

Add keyword LABEL_REVISION_NOTE.
Remove keyword RECORD_TYPE.
Need OBJECT = DATA_SET above DATA_SET_ID and END_OBJECT = DATA_SET
 above END.
The value for DATA_OBJECT_TYPE is TABLE.
CONFIDENCE_LEVEL_NOTE needs to be moved to after DATA_SET_DESC and
 should contain information about "Data Coverage and Quality" and 
 "Limitations"
Change double quotes (") to single quotes (') in line 317.
Under DATA LEVELS some of the DATA subdirectory names are inconsistent
 with those on the volume. In addition you don't refer to FRV files
 as being in the UNCALIBR directory.
REFERENCE_DESC is not included here since it should be in
 the *REF.CAT file.


INST.CAT:

Remove keyword RECORD_TYPE.
KUNDE90, CALCUTT92, MARTIN69 need to be in *REF.CAT and listed at the bottom of
 this file in INSTRUMENT_REFERENCE_INFO.
Is the Integration time listed correctly?
Remove $'s on line 49.
Typos in lines 70-71.
KUNDE1996 needs to be KUNDEETAL1996 to be consistent with that in DATASET.CAT.

PERSON.CAT:

Remove keyword RECORD_TYPE.
Update LABEL_REVISION_NOTE.


DATASIS.LBL:

The DESCRIPTION fields are a little curious.
The pointer ^ASCII_DOCUMENT can be ^LATEX_DOCUMENT (and the OBJECT and
 END_OBJECT adjusted accordingly). (And same for VOLSIS.LBL.)


DATAINFO.TXT:

Missing the following data types and their corresponding .FMT files:
 SPM, HSK, AIFM, CIFM, IFGM, SDAV, FRV






Lyle Huber
PDS Atmospheres Node